Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump assets-controllers to v37 #26984

Merged
merged 36 commits into from
Sep 18, 2024
Merged

chore: bump assets-controllers to v37 #26984

merged 36 commits into from
Sep 18, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Sep 9, 2024 •
edited
Loading

Description

Bump assets-controllers to v37

Open in GitHub Codespaces

Related issues

Fixes:
Related: https://github.com/MetaMask/core/blob/main/packages/assets-controllers/CHANGELOG.md#3700

Manual testing steps

  1. Go to NFTs tab, make sure you are able to see your NFTs and NFT details.
  2. Use Test-dapp to watch-NFTs and make sure you are able to add your NFTs.
  3. Make sure token detection is working

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Sep 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@37.0.0 None 0 1.73 MB metamaskbot
npm/@metamask/polling-controller@9.0.1 None 0 138 kB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@36.0.0, npm/@metamask/polling-controller@9.0.0, npm/@metamask/preferences-controller@13.0.0

View full report↗︎

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [e1b952e]
Page Load Metrics (1743 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint146221681746224107
domContentLoaded145521551729220106
load146321711743223107
domInteractive17178423919
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.15 KiB (-0.03%)
  • ui: 3.74 KiB (0.05%)
  • common: 3.49 KiB (0.04%)

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (c4c8fd7) to head (82b3271).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
ui/components/ui/identicon/identicon.component.js 84.62% 2 Missing ⚠️
...ichain/pages/send/components/recipient-content.tsx 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26984      +/-   ##
===========================================
+ Coverage    70.03%   70.12%   +0.09%     
===========================================
  Files         1443     1445       +2     
  Lines        50169    50229      +60     
  Branches     14041    14053      +12     
===========================================
+ Hits         35131    35220      +89     
+ Misses       15038    15009      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [30e7e36]
Page Load Metrics (1788 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22724341637526252
domContentLoaded150624281771239115
load151024331788246118
domInteractive12157393014
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.15 KiB (-0.03%)
  • ui: 3.74 KiB (0.05%)
  • common: 3.49 KiB (0.04%)

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Sep 9, 2024
@sahar-fehri sahar-fehri marked this pull request as ready for review September 9, 2024 21:57
@sahar-fehri sahar-fehri requested review from a team as code owners September 9, 2024 21:57
@metamaskbot
Copy link
Collaborator

Builds ready [8d7d88e]
Page Load Metrics (1660 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23520171513407196
domContentLoaded14721992163014670
load14811998166014871
domInteractive2099432412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.15 KiB (-0.03%)
  • ui: 3.74 KiB (0.05%)
  • common: 3.46 KiB (0.04%)

legobeat
legobeat reviewed Sep 10, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [6ca9c85]
Page Load Metrics (1914 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24029381654670322
domContentLoaded148729121889344165
load149529171914345166
domInteractive137240136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.15 KiB (-0.03%)
  • ui: 3.74 KiB (0.05%)
  • common: 3.46 KiB (0.04%)

gambinish
gambinish previously approved these changes Sep 17, 2024
View reviewed changes
vinnyhoward
vinnyhoward previously approved these changes Sep 17, 2024
View reviewed changes
gambinish
gambinish previously approved these changes Sep 17, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [96b56f4]
Page Load Metrics (1768 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15772077176612058
domContentLoaded15692027173611254
load15782079176812158
domInteractive19155423014
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.76 KiB (-0.05%)
  • ui: 3.78 KiB (0.05%)
  • common: 3.42 KiB (0.04%)

vinnyhoward
vinnyhoward previously approved these changes Sep 17, 2024
View reviewed changes
bergeron
bergeron previously approved these changes Sep 17, 2024
View reviewed changes
salimtb
salimtb previously approved these changes Sep 17, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [4b7eeb6]
Page Load Metrics (1957 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37524111894400192
domContentLoaded17032388192720397
load17152395195720297
domInteractive158340199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.76 KiB (-0.05%)
  • ui: 3.78 KiB (0.05%)
  • common: 3.42 KiB (0.04%)

OGPoyraz
OGPoyraz approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [82b3271]
Page Load Metrics (1901 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16022222190019091
domContentLoaded15942210185918991
load16022226190119192
domInteractive15106432311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.76 KiB (-0.05%)
  • ui: 3.78 KiB (0.05%)
  • common: 3.42 KiB (0.04%)

@sahar-fehri sahar-fehri merged commit 97dce9f into develop Sep 18, 2024
78 checks passed
@sahar-fehri sahar-fehri deleted the feat/upgrade-assets-controllers-to-v37 branch September 18, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 18, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@salimtb salimtb salimtb approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@bergeron bergeron bergeron approved these changes

@gambinish gambinish gambinish left review comments

@legobeat legobeat Awaiting requested review from legobeat

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sahar-fehri @metamaskbot @bergeron @OGPoyraz @salimtb @vinnyhoward @gambinish @legobeat